[release/v25.1.x] PVCUnbinder: Restore and flag claimRef clearing#915
Merged
chrisseto merged 1 commit intorelease/v25.1.xfrom Jun 13, 2025
Merged
[release/v25.1.x] PVCUnbinder: Restore and flag claimRef clearing#915chrisseto merged 1 commit intorelease/v25.1.xfrom
chrisseto merged 1 commit intorelease/v25.1.xfrom
Conversation
This reverts commit a89e202 and adds the CLI flag `--allow-pv-rebinding` to opt into the un-reverted functionality. A recent incident hit an exceptional edge case where all redpanda Pods where temporarily stuck in "Pending". Their underlying Nodes were marked as "NotReady" which caused the TaintManager to evict said Pods and prevented them from being rescheduled. The unbinder functioned as expected but due to the reverted commit the still existing PVs were not eligible for rebinding. As a result, a new cluster was formed. The original motivation for the reverted commit was due to an edge case where a Node's name was reused in EKS due to using Node IPs as their name. Our cloud has since begun using the instance ID as the Node name. To remain on the conservative side, we've opted to make this functionality opt in. (cherry picked from commit 162ef60)
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
andrewstucki
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintorelease/v25.1.x:Questions ?
Please refer to the Backport tool documentation