operator: refactor run parametrization#921
Merged
RafalKorepta merged 2 commits intomainfrom Jul 10, 2025
Merged
Conversation
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
RafalKorepta
approved these changes
Jun 17, 2025
chrisseto
force-pushed
the
chris/p/k8s-586-refactor-run
branch
from
699bf43 to
2325df5
Compare
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
RafalKorepta
force-pushed
the
chris/p/k8s-586-refactor-run
branch
from
2325df5 to
09e323f
Compare
RafalKorepta
force-pushed
the
chris/p/k8s-586-refactor-run
branch
2 times, most recently
from
9bc8dd9 to
38bbfe4
Compare
The `Run` entrypoint of the operator had a nasty case of "too many parameters" syndrome combined with a lot of needless duplication. This commit extracts all CLI parameters into a monolithic struct and removes intermediate variables where possible. The end result is still fairly sprawling but has fewer moving parts than the previous iteration.
In the execution sometimes the schema registry subsystem is not ready to handle requests. To make test suite more stable single assertion was replaced with Eventually function. To add more the stdout was not reset after each rpk command. Now it will be truncated.
RafalKorepta
force-pushed
the
chris/p/k8s-586-refactor-run
branch
from
38bbfe4 to
4c581ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Runentrypoint of the operator had a nasty case of "too many parameters" syndrome combined with a lot of needless duplication.This commit extracts all CLI parameters into a monolithic struct and removes intermediate variables where possible. The end result is still fairly sprawling but has fewer moving parts than the previous iteration.