Skip to content

[25.x] Use hashed properties rather than version #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewstucki merged 3 commits into from
Jun 18, 2025
Merged

[25.x] Use hashed properties rather than version #922

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cfef32
use hashed pro
andrewstucki Jun 17, 2025
bfbeb25
add changelog
andrewstucki Jun 17, 2025
92e4342
Add regression test
andrewstucki Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changes/unreleased/operator-Fixed-20250617-113325.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
project: operator
kind: Fixed
body: Fixed a bug where pods would be restarted indefinitely in the case of config version changes when syncing cluster configuration.
time: 2025-06-17T11:33:25.480184-04:00
1 change: 1 addition & 0 deletions operator/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ This is required to ensure that a pre-existing sts can roll over to new configur
* `get` permissions on `Node` resources is now correctly configured by default.

`--set rbac.createAdditionalControllerCRs=true` is no longer required for rackawareness to work.
* Fixed a bug where pods would be restarted indefinitely in the case of config version changes when syncing cluster configuration.

## [v25.1.1-beta3](https://github.com/redpanda-data/redpanda-operator/releases/tag/operator%2Fv25.1.1-beta3) - 2025-05-07
### Added
Expand Down
4 changes: 1 addition & 3 deletions operator/internal/controller/redpanda/redpanda_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
"bytes"
"context"
"fmt"
"strconv"
"strings"
"time"

Expand Down Expand Up @@ -606,8 +605,7 @@ func (r *RedpandaReconciler) reconcileClusterConfig(ctx context.Context, admin *
return "", false, errors.WithStack(err)
}

// TODO: this needs to be updated when the hashing code lands
return strconv.FormatInt(configStatus.Version, 10), configStatus.NeedsRestart, nil
return configStatus.PropertiesThatNeedRestartHash, configStatus.NeedsRestart, nil
}

func (r *RedpandaReconciler) configSyncMode(ctx context.Context, rp *redpandav1alpha2.Redpanda) syncclusterconfig.SyncerMode {
Expand Down