redpanda: correct Role and ClusterRole naming #927
Merged
RafalKorepta merged 2 commits intomainfrom Jun 20, 2025
Merged
Conversation
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
chrisseto
force-pushed
the
chris/p/k8s-661-rbac-naming
branch
2 times, most recently
from
ac72c01 to
edf1dba
Compare
chrisseto
commented
Jun 19, 2025
| } | ||
|
|
||
| select { | ||
| case <-time.After(10 * time.Second): |
Contributor
Author
There was a problem hiding this comment.
I'm opting to not make this configurable for now as I don't see a particularly pressing reason to do so.
chrisseto
commented
Jun 19, 2025
| // continuously refreshed via [Ctl.Get] before calling cond. If ctx does not | ||
| // have a deadline a default of 5m will be used. | ||
| func (c *Ctl) WaitFor(ctx context.Context, obj Object, cond CondFn[Object]) error { | ||
| const timeout = 5 * time.Minute |
Contributor
Author
There was a problem hiding this comment.
This is configurable by passing in a context with a deadline attached.
This commit improves the ergonomics of the kube.Ctl struct by allowing configuration with variadic options and implementing Apply. These improvements have been carried over to the kubetest.NewEnv function as well. Most notably, this allows specifying the Scheme of the testenv which makes it useable when testing CRDs.
In 5d72f8a, the Names for `Role`s generated by the chart were mistakenly changed from `Fullname` to `Name`. This regression went by unnoticed as we did not have any tests that installed multiple instances of the chart into a single namespace. This commit corrects the regression and updates the naming of `ClusterRole`s to include the release namespace. This allows: - Installing multiple instances of the chart into a single namespace. - Installing multiple instances of the chart with the same release name into different namespaces.
chrisseto
force-pushed
the
chris/p/k8s-661-rbac-naming
branch
from
edf1dba to
e9a6919
Compare
RafalKorepta
approved these changes
Jun 20, 2025
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
|
@chris @RafalKorepta This should be backported for 2.4.x and 2.3.x as well |
This was referenced Jun 26, 2025
Merged
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 similar comment
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 5d72f8a, the Names for
Roles generated bythe chart were mistakenly changed from
FullnametoName. This regressionwent by unnoticed as we did not have any tests that installed multiple
instances of the chart into a single namespace.
This commit corrects the regression and updates the naming of
ClusterRoles toinclude the release namespace. This allows: