-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Migrate to React 19 #4409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Migrate to React 19 #4409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 19acec8:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ec60b9a to
c1c42eb
Compare
60fa41a to
48084da
Compare
ad370d1 to
9abb7ac
Compare
5cd1cad to
29aea28
Compare
bc3b72b to
8fb2a7c
Compare
2 tasks
0216535 to
a80512a
Compare
7bca2a8 to
4f645a8
Compare
…iddleware.test.ts`
- We set the `@types/react` and `@types/react-dom` package resolutions to `npm:types-react` and `npm:types-react-dom` according to the React 19 migration guide.
- This was done to make sure `toHaveBeenCalledWith` will fail if we pass in the wrong Error constructor. For example the assertion will now fail if we pass in an `Error` instead of a `TypeError`.
- This was done because it was causing the unit tests in example workspaces to fail.
9014399 to
6410899
Compare
1e03314 to
19acec8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
reactandreact-domto v19.@types/reactand@types/react-domto v19 according to the React 19 migration guide.@testing-library/reactto latest version.@testing-library/user-eventto latest version.@testing-library/dom.ReactDOM.rendercalls with therenderfunction from@testing-library/reactas recommended in the React 19 migration guide.ReactDOM.unmountComponentAtNodecalls with theunmountfunction from@testing-library/reactas recommended in the React 19 migration guide.actwrappers aroundfireEventmethod calls since they are already wrapped inactcalls.reactinpeerDependenciesto include version 19.consolespies.actwarnings emitted by@testing-library/react.sinonfake timers.