Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/toolkit/src/query/react/buildHooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1661,8 +1661,6 @@ export function buildHooks<Definitions extends EndpointDefinitions>({
skipPollingIfUnfocused,
})

const lastRenderHadSubscription = useRef(false)

const initialPageParam = (rest as UseInfiniteQuerySubscriptionOptions<any>)
.initialPageParam
const stableInitialPageParam = useShallowStableValue(initialPageParam)
Expand All @@ -1686,11 +1684,7 @@ export function buildHooks<Definitions extends EndpointDefinitions>({
}

const subscriptionRemoved =
!currentRenderHasSubscription && lastRenderHadSubscription.current

usePossiblyImmediateEffect(() => {
lastRenderHadSubscription.current = currentRenderHasSubscription
})
!currentRenderHasSubscription && promiseRef.current !== undefined

usePossiblyImmediateEffect((): void | undefined => {
if (subscriptionRemoved) {
Expand Down
65 changes: 65 additions & 0 deletions packages/toolkit/src/query/tests/buildHooks.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,71 @@ describe('hooks tests', () => {
status: 'uninitialized',
})
})

test('hook should not be stuck loading post resetApiState after re-render', async () => {
const user = userEvent.setup()

function QueryComponent() {
const { isLoading, data } = api.endpoints.getUser.useQuery(1)

if (isLoading) {
return <p>Loading...</p>
}

return <p>{data?.name}</p>
}

function Wrapper() {
const [open, setOpen] = useState(true)

const handleRerender = () => {
setOpen(false)
setTimeout(() => {
setOpen(true)
}, 1000)
}

const handleReset = () => {
storeRef.store.dispatch(api.util.resetApiState())
}

return (
<>
<button onClick={handleRerender} aria-label="Rerender component">
Rerender
</button>
{open ? (
<div>
<button onClick={handleReset} aria-label="Reset API state">
Reset
</button>

<QueryComponent />
</div>
) : null}
</>
)
}

render(<Wrapper />, { wrapper: storeRef.wrapper })

await user.click(
screen.getByRole('button', { name: /Rerender component/i }),
)
await waitFor(() => {
expect(screen.getByText('Timmy')).toBeTruthy()
})

await user.click(
screen.getByRole('button', { name: /reset api state/i }),
)
await waitFor(() => {
expect(screen.queryByText('Loading...')).toBeNull()
})
await waitFor(() => {
expect(screen.getByText('Timmy')).toBeTruthy()
})
})
})

test('useQuery refetch method returns a promise that resolves with the result', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/toolkit/src/query/tests/createApi.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,7 @@ describe('timeout behavior', () => {
http.get(
'https://example.com/success',
async () => {
await delay(10)
await delay(50)
return HttpResponse.json({ value: 'failed' }, { status: 500 })
},
{ once: true },
Expand Down