Skip to content

Update TS CI config #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2025
Merged

Update TS CI config #5065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
821be20
Add TS 5.9 to the matrix
markerikson Sep 1, 2025
38537c3
Don't run Node10 checks for TS 6+
markerikson Sep 1, 2025
c37b977
Add missing error value
markerikson Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ jobs:
fail-fast: false
matrix:
node: ['22.x']
ts: ['5.3', '5.4', '5.5', '5.6', '5.7', '5.8', 'next']
ts: ['5.3', '5.4', '5.5', '5.6', '5.7', '5.8', '5.9', 'next']
example:
[
{ name: 'bundler', moduleResolution: 'Bundler' },
Expand Down Expand Up @@ -340,10 +340,11 @@ jobs:
run: yarn workspace @examples-type-portability/${{ matrix.example.name }} run test

- name: Test type portability with `moduleResolution Node10`
if: matrix.ts != 'next' && !startsWith(matrix.ts, '6.')
run: yarn workspace @examples-type-portability/${{ matrix.example.name }} run test --module CommonJS --moduleResolution Node10 --preserveSymLinks --verbatimModuleSyntax false

- name: Test type portability with `moduleResolution Node10` and `type module` in `package.json`
if: matrix.example.name == 'nodenext-esm' || matrix.example.name == 'bundler'
if: (matrix.example.name == 'nodenext-esm' || matrix.example.name == 'bundler') && matrix.ts != 'next' && !startsWith(matrix.ts, '6.')
run: |
npm --workspace=@examples-type-portability/${{ matrix.example.name }} pkg set type=module
yarn workspace @examples-type-portability/${{ matrix.example.name }} run test --module ESNext --moduleResolution Node10 --preserveSymLinks --verbatimModuleSyntax false
3 changes: 2 additions & 1 deletion errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,6 @@
"39": "called \\`injectEndpoints\\` to override already-existing endpointName without specifying \\`overrideExisting: true\\`",
"40": "maxPages for endpoint '' must be a number greater than 0",
"41": "getPreviousPageParam for endpoint '' must be a function if maxPages is used",
"42": "Duplicate middleware references found when creating the store. Ensure that each middleware is only included once."
"42": "Duplicate middleware references found when creating the store. Ensure that each middleware is only included once.",
"43": "`builder.addAsyncThunk` should only be called before calling `builder.addDefaultCase`"
}
Loading