Skip to content

Add secrets.token_hex for seed #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mlech-reef wants to merge 5 commits into from
Closed

Add secrets.token_hex for seed #345

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1f651c
Add secrets.token_hex for seed
mlech-reef Aug 26, 2025
184aa67
Increase entropy for RNG seed
mlech-reef Aug 26, 2025
3df9f4b
Use OS entropy for seeds
mlech-reef Aug 26, 2025
e01f531
Use random.org TRNG entropy
mlech-reef Aug 26, 2025
7624a48
Do not use global random generator for creating bucket names
mlech-reef Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions test/integration/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,18 @@ def get_seed() -> str:
"""
seed = ''.join(
(
os.getenv('WORKFLOW_ID', secrets.token_hex(8)),
NODE_DESCRIPTION,
secrets.token_hex(),
str(time.time_ns()),
os.getenv('WORKFLOW_ID', ''),
NODE_DESCRIPTION,
os.getenv('PYTEST_XDIST_WORKER', 'gw0'),
)
)
return sha256(seed.encode()).hexdigest()[:16]
return sha256(seed.encode()).hexdigest()


RNG_SEED = get_seed()
RNG = random.Random(RNG_SEED)
RNG_COUNTER = 0

if sys.version_info < (3, 9):
RNG.randbytes = lambda n: RNG.getrandbits(n * 8).to_bytes(n, 'little')
Expand All @@ -118,18 +118,16 @@ def get_seed() -> str:


def random_token(length: int, chars=string.ascii_letters) -> str:
return ''.join(RNG.choice(chars) for _ in range(length))
seed = get_seed()
logger.info('random_token seed: %s', seed)
rng = random.Random(seed)
return ''.join(rng.choice(chars) for _ in range(length))


def bucket_name_part(length: int) -> str:
assert length >= 1
global RNG_COUNTER
RNG_COUNTER += 1
name_part = random_token(length, BUCKET_NAME_CHARS_UNIQ)
logger.info('RNG_SEED: %s', RNG_SEED)
logger.info('RNG_COUNTER: %i, length: %i', RNG_COUNTER, length)
logger.info('name_part: %s', name_part)
logger.info('WORKFLOW_ID: %s', os.getenv('WORKFLOW_ID'))
return name_part


Expand Down
Loading