[TEST - DO NOT MERGE] Verify CI catches buffer overflow #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport This commit addresses issue Backblaze#1119 where B2 CLI crashes with SystemError on Python 3.14+ due to a buffer overflow bug in the rst2ansi dependency. Changes: - Add try-except handler in arg_parser.py to catch SystemError from rst2ansi - Fall back to plain text formatting when rst2ansi fails - Add integration test to verify the fix works with real PTY on Python 3.14 - Add dedicated nox session (integration_pty) for PTY tests without xdist - Add Python 3.14 to noxfile.py, CI matrix, and pyproject.toml The root cause is in rst2ansi's get_terminal_size() which passes a 4-byte buffer to TIOCGWINSZ ioctl instead of the required 8 bytes. Python 3.14 enforces stricter buffer validation, triggering the error. Fixes Backblaze#1119
The PTY test doesn't work properly with pytest-xdist parallelization. Instead of a dedicated nox session, run it directly in CI on Python 3.14 without xdist to properly test the buffer overflow fix.
This is a test commit to validate that our CI setup properly detects the buffer overflow bug. This should FAIL on Python 3.14 PTY test. DO NOT MERGE - This is intentionally broken to test CI.
The condition needs to be wrapped in ${{ }} for proper evaluation.
Collaborator
Author
|
✅ Validation successful! The regular integration tests correctly catch the buffer overflow bug on Python 3.14. The test fails as expected when the fix is not present, confirming our CI setup works properly. No need for a separate PTY test step - the standard integration tests with pytest-xdist are sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intentionally reverts the buffer overflow fix to verify that our CI setup properly catches the bug on Python 3.14.
Expected result: The regular integration tests (with pytest-xdist) should FAIL on Python 3.14 when running test_help_with_tty.
If it fails as expected, we know our simplified CI setup works correctly and we can close this PR.