BLD: since we already use setuptools, let's remove the optional logic…

[ghost]

… in setup.py (GH18113).

• closes BLD: since we already use setuptools, let's remove the optional logic in setup.py pandas-dev/pandas#18113
• tests passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[brychlicki-reef]

Consider removing the second check in

pandas/setup.py

Line 645 in 2bd0ffc

if suffix == '.pyx' and 'setuptools' in sys.modules:

'setuptools' in sys.modules

is always True

[brychlicki-reef]

👍
I did not find anything beyond the above #4 (comment) . And I am not that certain it should be removed, it won't fail and documents the actual conditions when the bug described in next line happens. Use your best judgement, I would still lean towards removing it as the path to not having setuptools in setup.py is closed IMO.

[brychlicki-reef]

I also checked if any other dependencies to distutils can be removed, namely I checked if

pandas/setup.py

Line 15 in 2bd0ffc

from distutils.version import LooseVersion

was possibly reimplemented in setuptools and no, it was not, that was a dead end.

[ghost]

Thank you for the review 👍
Fixed applied according to #4 (comment)

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@c634352). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   91.34%           
=========================================
  Files             ?      163           
  Lines             ?    49691           
  Branches          ?        0           
=========================================
  Hits              ?    45388           
  Misses            ?     4303           
  Partials          ?        0

Flag	Coverage Δ
#multiple	89.14% <ø> (?)
#single	39.67% <ø> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c634352...62254e5. Read the comment docs.