BUG: fillna maximum recursion depth exceeded in cmp (GH18159). #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
18159
branch
4 times, most recently
from
9884e41 to
254193b
Compare
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=========================================
Coverage ? 91.58%
=========================================
Files ? 153
Lines ? 51250
Branches ? 0
=========================================
Hits ? 46938
Misses ? 4312
Partials ? 0
Continue to review full report at Codecov.
|
pandas/core/internals.py
Outdated
| return (isinstance(element, (float, int, np.floating, np.int_)) and | ||
| not isinstance(element, (bool, np.bool_, datetime, timedelta, | ||
| return ( | ||
| isinstance(element, (float, int, np.floating, np.int_, np.long)) |
There was a problem hiding this comment.
I see you have addd np.long here. What do you think about adding a test for that case, exactly same as in original issue on Github?
ghost
force-pushed
the
18159
branch
2 times, most recently
from
47406dd to
998ee68
Compare
gkonefal-reef
approved these changes
Nov 13, 2017
|
Squash commits please, then proceed with PR to upstream. |
ghost
force-pushed
the
18159
branch
4 times, most recently
from
54303dd to
7380624
Compare
dmanikowski-reef
force-pushed
the
master
branch
from
0e42b1f to
1647a72
Compare
gkonefal-reef
force-pushed
the
18159
branch
3 times, most recently
from
c21485f to
7474a3b
Compare
…with both tz-naive and tz-aware (pandas-dev#18361)
…#18388) Added teardowns for hdfstore, io and packers benchmarks.
closes pandas-dev#18113 Author: Grzegorz Konefał <[email protected]> Author: Krzysztof Chomski <[email protected]> Closes pandas-dev#18448 from gkonefal-reef/GH18113 and squashes the following commits: 21cbe79 [Grzegorz Konefał] Comments applied 290b49c [Krzysztof Chomski] BLD: since we already use setuptools, let's remove the optional logic in setup.py (GH18113).
gkonefal-reef
force-pushed
the
18159
branch
2 times, most recently
from
fdef49a to
fe7360c
Compare
Deprecated in 0.19.0. xref pandas-devgh-14007.
Deprecated in 0.17.0. xref pandas-devgh-13735.
Deprecated in 0.19.0 xref pandas-devgh-13854.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
37 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff