Unicode support #81
Unicode support #81
Conversation
ccoVeille
left a comment
ccoVeille
left a comment
There was a problem hiding this comment.
LGTM 👍
I made a small feedback as I feel like the code could be simpler
internal/core/keys.go
Outdated
| // PeekChar returns the first character in the stack, without removing it. | ||
| func PeekChar(keys *Keys) (key string, empty bool) { | ||
| bufStr := []rune(string(keys.buf)) | ||
| switch { | ||
| case len(bufStr) > 0: | ||
| key = string(bufStr[0]) | ||
| default: | ||
| return "", true | ||
| } | ||
|
|
||
| return key, false | ||
| } |
There was a problem hiding this comment.
What about this?
| // PeekChar returns the first character in the stack, without removing it. | |
| func PeekChar(keys *Keys) (key string, empty bool) { | |
| bufStr := []rune(string(keys.buf)) | |
| switch { | |
| case len(bufStr) > 0: | |
| key = string(bufStr[0]) | |
| default: | |
| return "", true | |
| } | |
| return key, false | |
| } | |
| // PeekChar returns the first character in the stack, without removing it. | |
| func PeekChar(keys *Keys) (key string, empty bool) { | |
| if len(keys.buf) == 0 { | |
| return "", true | |
| } | |
| return []rune(string(keys.buf))[0], false | |
| } |
There was a problem hiding this comment.
Thanks, I have made some changes to this function.
|
Awecome! Can we expect this PR to be accepted and a new version of readline package created? Thx in advance! |
|
Hello @h3x0c4t, @ccoVeille, Thanks a lot for your PR. Thanks again. |
|
Hello @h3x0c4t and @ccoVeille, I wanted to know if you found any functionality bug related to this change ? Thanks in advance |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
===========================================
- Coverage 89.30% 34.31% -55.00%
===========================================
Files 10 57 +47
Lines 4739 12620 +7881
===========================================
+ Hits 4232 4330 +98
- Misses 470 8252 +7782
- Partials 37 38 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
unicode support simplified Adapt key-matching code to support Unicode Fix comment typo
4 participants
Hi!
I use readline and console in my project and I needed Cyrillic support, so I added the ability to enter unicode characters :)