Skip to content

Fix lints and tests #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Fix lints and tests #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e22d277
Don't remove rustfmt wrapper
mbrubeck Jul 23, 2025
33bdc20
Use new-style format strings
mbrubeck Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ jobs:
rustup toolchain install ${{ matrix.rust }} --profile=minimal
rustup override set ${{ matrix.rust }}

- name: Install rustfmt + clippy
if: matrix.rust == 'stable'
run: |
# remove non-rustup-managed versions already present in default image
rm -f /home/runner/.cargo/bin/{rustfmt,cargo-fmt}

rustup toolchain install ${{ matrix.rust }} --profile=minimal --component=clippy,rustfmt

- name: Check Fmt
if: matrix.rust == 'stable'
run: cargo fmt --check
Expand Down
4 changes: 2 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1911,7 +1911,7 @@ impl<E: fmt::Debug + Error + 'static> Error for ParseNotNanError<E> {
impl<E: fmt::Display> fmt::Display for ParseNotNanError<E> {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
match self {
ParseNotNanError::ParseFloatError(e) => write!(f, "Parse error: {}", e),
ParseNotNanError::ParseFloatError(e) => write!(f, "Parse error: {e}"),
ParseNotNanError::IsNaN => write!(f, "NotNan parser encounter a NaN"),
}
}
Expand Down Expand Up @@ -2333,7 +2333,7 @@ mod impl_speedy {
fn read_from<R: Reader<'a, C>>(reader: &mut R) -> Result<Self, C::Error> {
let value: T = reader.read_value()?;
Self::new(value).map_err(|error| {
speedy::Error::custom(std::format!("failed to read NotNan: {}", error)).into()
speedy::Error::custom(std::format!("failed to read NotNan: {error}")).into()
})
}

Expand Down
4 changes: 2 additions & 2 deletions tests/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ fn hash_is_good_for_whole_numbers() {
// many, but should guard against transient issues
// that will result from using RandomState
let pct_unique = set.len() as f64 / limit as f64;
assert!(0.99f64 < pct_unique, "percent-unique={}", pct_unique);
assert!(0.99f64 < pct_unique, "percent-unique={pct_unique}");
}

#[test]
Expand All @@ -494,7 +494,7 @@ fn hash_is_good_for_fractional_numbers() {
// many, but should guard against transient issues
// that will result from using RandomState
let pct_unique = set.len() as f64 / limit as f64;
assert!(0.99f64 < pct_unique, "percent-unique={}", pct_unique);
assert!(0.99f64 < pct_unique, "percent-unique={pct_unique}");
}

#[test]
Expand Down