Skip to content

Reduce Swift Runtime Overhead #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnixx merged 3 commits into from
Sep 8, 2025
Merged

Reduce Swift Runtime Overhead #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
933c37d
reduce swift runtime overhead
ChrisBenua Sep 5, 2025
1ce7be9
handle unknown default value
ChrisBenua Sep 5, 2025
7c65a6d
move to utilities
ChrisBenua Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/ReerJSON/JSONDecoderImpl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ final class JSONDecoderImpl: Decoder {
if type == Decimal.self {
return try unboxDecimal(from: value, for: codingPathNode, additionalKey) as! T
}
if let dictType = type as? StringDecodableDictionary.Type {
if !options.keyDecodingStrategy.isDefault, let dictType = type as? StringDecodableDictionary.Type {
return try unboxDictionary(from: value, as: dictType, for: codingPathNode, additionalKey)
}

Expand Down
12 changes: 12 additions & 0 deletions Sources/ReerJSON/Utilities.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,18 @@ extension Dictionary : StringDecodableDictionary where Key == String, Value: Dec
static var elementType: Decodable.Type { return Value.self }
}

extension JSONDecoder.KeyDecodingStrategy {
@inline(__always)
var isDefault: Bool {
switch self {
case .useDefaultKeys:
return true
default:
return false
}
}
}

// This is a workaround for the lack of a "set value only if absent" function for Dictionary.
extension Optional {
mutating func _setIfNil(to value: Wrapped) {
Expand Down