Skip to content

update-pr-from-base-branch - Don't duplicate the native button #8489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Jun 24, 2025

Close: #8479

Test URLs

Screenshot

Situation Screenshot Test URL
PR without conflicts CleanShot 2025-06-24 at 09 13 54 refined-github/sandbox#60
Draft PR without conflicts CleanShot 2025-06-24 at 09 16 02 refined-github/sandbox#61
Native "Update branch" button CleanShot 2025-06-24 at 09 19 31 -
Native "Resolve conflicts" button CleanShot 2025-06-24 at 09 17 28 refined-github/sandbox#9
Cross-repo PR with long branch names CleanShot 2025-06-24 at 09 26 29 refined-github/sandbox#13
PRs to repos without write access CleanShot 2025-06-24 at 09 19 31 -

@kovsu kovsu marked this pull request as ready for review June 24, 2025 01:37
@kovsu
Copy link
Member Author

kovsu commented Jun 24, 2025

It seems like pr-base-commit is also broken.

@fregante
Copy link
Member

Yes that feature has also been broken for a while and it's one of the most useful ones to me 🥹

@fregante fregante merged commit 3634eb9 into refined-github:main Jun 24, 2025
9 checks passed
@fregante fregante changed the title update-pr-from-base-branch - Duplicated button update-pr-from-base-branch - Don't duplicate the native button Jun 24, 2025
@kovsu kovsu deleted the fix-#8479 branch June 24, 2025 03:42
@fregante fregante added the bug label Jun 30, 2025
@fregante
Copy link
Member

fregante commented Jul 1, 2025

If there are more issues with this feature, by all means feel free to rewrite it and drop GHE compatibility, maybe reusing the selectors from

@fregante
Copy link
Member

fregante commented Jul 1, 2025

Side note, the button is partially obstructed, it cannot be clicked on the bottom

ko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Duplicated “Update Branch” button
2 participants