Skip to content

Conversation

@mistervaibhav
Copy link

@mistervaibhav mistervaibhav commented Jan 5, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behaviour?

Latest Antd is not supported

What is the new behaviour?

Antd is updated internally to the latest version

fixes (#7140)

Notes for reviewers

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2026

🦋 Changeset detected

Latest commit: 4cc1386

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/antd Minor
@refinedev/inferencer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mistervaibhav mistervaibhav marked this pull request as ready for review January 5, 2026 07:40
@mistervaibhav mistervaibhav requested a review from a team as a code owner January 5, 2026 07:40
Copy link
Member

@alicanerdurmaz alicanerdurmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some example tests are failing. Could you please look into this?

You can check this document to see how to run the tests:
https://refine.dev/core/docs/guides-concepts/contributing/#running-tests

@mistervaibhav
Copy link
Author

Some example tests are failing. Could you please look into this?

You can check this document to see how to run the tests: https://refine.dev/core/docs/guides-concepts/contributing/#running-tests

yes, will fix them as soon as I can

@alicanerdurmaz
Copy link
Member

Hello @mistervaibhav,

The PR looks great 🙌 However, there are still some CI errors. When you have time, once you fix the remaining issues, we’ll start the review.

Thanks a lot for contributing to Refine 🚀

@Gzbox
Copy link

Gzbox commented Jan 22, 2026

Hi @mistervaibhav! I'm also eager to see the antd v6 upgrade merged soon, so I took the liberty of investigating the CI failure and found a fix.

The fix is in packages/antd/src/hooks/drawer/useDrawer/index.tsx:

-      onClose: (e: React.MouseEvent | React.KeyboardEvent) => {
+      onClose: (
+        e: Parameters<NonNullable<DrawerProps["onClose"]>>[0],
+      ) => {

The onClose event type changed in antd v6 to include native KeyboardEvent. Using Parameters<NonNullable<DrawerProps["onClose"]>>[0] extracts the correct type directly from antd's DrawerProps, making it compatible with both current and future versions.

This should fix all the "Build All Examples" CI failures.

Hope this helps!

@mistervaibhav
Copy link
Author

Sure @Gzbox, checking this out

@Gzbox
Copy link

Gzbox commented Jan 23, 2026

Thanks to the bosses
Keep following 👍

@mistervaibhav
Copy link
Author

Thanks alicanerdurmaz for looking into this PR.

I was able to run all tests successfully using pnpm test -- --scope @refinedev/antd, but I'm not sure whether this is sufficient for the "Build All Examples" CI run. Please let me know if there's anything else I should do.

image

Thanks Gzbox — your suggestions helped too, along with a few other changes.

@mistervaibhav mistervaibhav changed the title feat: upgrade to antd 6.1.3 feat: upgrade to antd 6.2.0 Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants