Domain Name based i18n #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I like the idea but I'm not sure if this should be included by default. How about putting this PR and refinery/refinerycms#2280 in a separate gem which would add this domain functionality to existing Refinery app. WDYT about this approach? |
Member
|
@ugisozols but than you'll need to override around_recognize :( |
Member
|
@simi yes. Is there a reason it shouldn't be done that way? |
ghost
assigned
Author
|
@ugisozols I think such a feature is essential to i18n. it is only a few lines of code. Maybe the way I do it is not perfect because I am new too all this. Let me know more about the details. |
Member
|
@benxao I agree that this feature is essential to i18n but I'm just trying to think of (arguably) better way to implement it. |
Member
|
@parndt do you think we can close this? |
Member
|
It's a nice feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have several domain names for the same website because the domain names are localised, allow refinery cms to pick locale base on domain name.
ex: www.iam-on-diet.com , www.je-fais-le-regime.fr