Interference Marketable Routes & ActiveStorage fixed

[Obi-TOB]

Closes #3383

[bricesanchez]

Thank you very much @Obi-TOB !

Should we also add rails/active_storageslug in friendly_id_reserved_words ?

We don't want to create a page with this slug and not able to reach it.

[Obi-TOB]

Hi @bricesanchez,

I added all words from all reserved_paths to the friendly_id_reserved_words.

I guess this might go a bit far... as this probably means no friendly_id slugs with rails or active storage. I'm not entirely sure how friendly id stores the slugs, but I think we need to exclude each word on it's own.

Let me know what you think...

[bricesanchez]

You probably just need to add rails because we already just add refinery or admin in friendly_id_reserved_words even if there are sub path to these paths.

[Obi-TOB]

I now add only the first elements from each element of reserved_paths to friendly_id_reserved_words, so in the case we have only one element '/rails/active_storage' it will only take 'rails'. If you add several paths it will remove all 'root'-fragments of the paths

[parndt]

maybe we could use:

self.friendly_id_reserved_words = %w(
  index new session login logout users refinery admin images
) | reserved_paths.map { |path| path.split('/') }.flatten.uniq.reject(&:blank?)

[Obi-TOB]

I changed it to

self.friendly_id_reserved_words = %w(
  index new session login logout users refinery admin images
) | self.reserved_paths.map { |path| path.split('/').reject(&:blank?).first}.flatten.uniq

to take only the all root_fragments of the reserved paths.

[bricesanchez]

Thanks @Obi-TOB !

I've just seen that the new config reserved_paths is missing pages initializer template : https://github.com/refinery/refinerycms/blob/master/pages/lib/generators/refinery/pages/templates/config/initializers/refinery/pages.rb.erb

Could you add it ?

[bricesanchez]

Closed in favor of #3387.