Feature/3389/search resource dialogs

[bricesanchez]

This fixes #3389

[bricesanchez]

Hi @parndt ! I don't find how i could render the template by context insert or in /refinery/admin/pages_dialogs/link_to template.

Using @callback is not the good way, could you help me to find?

[parndt]

oops you accidentally mentioned the @callback user 😉

[bricesanchez]

Oops! i will not expect a callback from this user 😆

[bricesanchez]

Any idea @parndt ?

[parndt]

shouldn't the s be optional? Like /^https?:\/\//

[bricesanchez]

right

[parndt]

reopened to activate code climate

[bricesanchez]

Hi @parndt, could you review my PR? Also, i think the PR config of codeclimate is too strict, could we just warning us?

[parndt]

The code looks fine. I think the code climate failures provide good points 😉

[bricesanchez]

I dont't really know if we still need these lines :

refinerycms/resources/app/controllers/refinery/admin/resources_controller.rb

Lines 49 to 55 in 10a6eee

	if params[:conditions].present?
	extra_condition = params[:conditions].split(',')
	extra_condition[1] = true if extra_condition[1] == "true"
	extra_condition[1] = false if extra_condition[1] == "false"
	extra_condition[1] = nil if extra_condition[1] == "nil"
	end

I don't really know if it still works since strong_paramaters

There is no spec for this lines : https://github.com/refinery/refinerycms/search?q=condition&unscoped_q=condition

[bricesanchez]

So @parndt will you acceptthis PR as it? :)

[parndt]

Yeah. I think that the other things can be done as separate refactors. I was looking at it the other night, but it was quite intense.