ENG-6307: Only scroll to a link in the sidebar#1432
Merged
Conversation
If the page loads slowly, then the js snippet might find a matching link in the footer and scroll to the bottom of the page instead of scrolling to expose the sidebar link.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Fixed sidebar scrolling behavior to prevent unintended scrolling to footer links during slow page loads by scoping the active link search to within the sidebar container only.
- Modified
pcweb/components/docpage/sidebar/sidebar.pyto add a specific container ID for the sidebar and restrict link matching to that container, preventing accidental scrolling to footer links
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Alek99
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the page loads slowly, then the js snippet might find a matching link in the footer and scroll to the bottom of the page instead of scrolling to expose the sidebar link.
Fixup from #1423