perfer to always use splat and optional catchcall#1436
Merged
adhami3310 merged 1 commit intomainfrom Jun 17, 2025
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Updates routing patterns and dependencies to standardize catch-all routes using splat parameter and modernize project requirements.
- Modified
/docs/library/chakra/[...component]to/docs/library/chakra/[[...splat]]inpcweb/pcweb.pyfor consistency - Updated dynamic routing docs in
docs/pages/dynamic_routing.mdto enforcesplatas the standard catch-all parameter name - Added
requirements.txtwith major upgrades: pandas 2.3.0 (Python 3.10+), OpenAI 1.78.1 (Python 3.8+), and new visualization packages - Switched from psycopg2-binary to psycopg3 for improved PostgreSQL support
3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| args = self.router.page.params | ||
| usernames = args.get('username', []) | ||
| usernames = args.get('splat', []) | ||
| return f"Posts by \{', '.join(usernames)}" |
Contributor
There was a problem hiding this comment.
logic: The string interpolation uses a backslash before the curly brace which will cause a syntax error
Suggested change
| return f"Posts by \{', '.join(usernames)}" | |
| return f"Posts by {', '.join(usernames)}" |
Comment on lines
+104
to
+107
| | `/products/[category]/[[...splat]]` | `/products/electronics` | valid | | ||
| | | `/products/electronics/laptops` | valid | | ||
| | | `/products/electronics/laptops/lenovo` | valid | | ||
| | | `/products/electronics/laptops/lenovo/thinkpad` | valid | |
Contributor
There was a problem hiding this comment.
style: This is a duplicate entry from lines 102-103, showing the same route pattern with the same behavior
Suggested change
| | `/products/[category]/[[...splat]]` | `/products/electronics` | valid | | |
| | | `/products/electronics/laptops` | valid | | |
| | | `/products/electronics/laptops/lenovo` | valid | | |
| | | `/products/electronics/laptops/lenovo/thinkpad` | valid | | |
| | `/products/[category]/[[...splat]]` | `/products/electronics/laptops` | valid | | |
| | | `/products/electronics/laptops/lenovo` | valid | |
Lendemor
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.