Skip to content

Ban .edu email domains in pricing form validation #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alek99 merged 4 commits into from
Jun 23, 2025
Merged

Ban .edu email domains in pricing form validation #1445

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
962389c
Ban .edu email domains in pricing form validation
devin-ai-integration[bot] Jun 23, 2025
adba2da
Fix formatting issues with ruff
devin-ai-integration[bot] Jun 23, 2025
da0518a
Fix formatting for all files affected by ruff format
devin-ai-integration[bot] Jun 23, 2025
ab39785
Update .edu domain validation to catch domains with .edu in middle
devin-ai-integration[bot] Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pcweb/pages/pricing/header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def submit(self, form_data: dict[str, Any]):
email = form_data.get("email", "").lower()
if "@" in email:
domain = email.split("@")[1]
if domain in banned_domains:
if domain in banned_domains or domain.endswith('.edu'):
Copy link
Contributor

@greptile-apps greptile-apps bot Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider using a dedicated error message for .edu emails (e.g., 'Educational institution emails are not allowed') instead of reusing 'Personal emails not allowed!'

self.banned_email = True
yield rx.set_focus("email")
return
Expand Down
Loading