-
Notifications
You must be signed in to change notification settings - Fork 231
ENG-8741: Web improvements #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Greptile OverviewGreptile SummaryThis PR implements web performance and accessibility improvements across the Reflex documentation and landing pages. The changes migrate from Google Fonts to self-hosted fonts with proper preload hints, enhance ARIA attributes throughout the navigation components, optimize image formats, and improve semantic HTML structure. Key Changes
Minor Issues
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Browser
participant Server
participant FontFiles as Font Files
participant Assets as Image Assets
Note over Browser,Assets: Page Load Sequence
Browser->>Server: Request HTML page
Server-->>Browser: HTML with preload hints
par Font Preloading
Browser->>FontFiles: Preload instrument-sans.woff2
Browser->>FontFiles: Preload jetbrains-mono.woff2
end
Browser->>Server: Request fonts.css
Server-->>Browser: Font-face definitions
Note over Browser,FontFiles: Fonts loaded from local assets<br/>instead of Google Fonts CDN
FontFiles-->>Browser: instrument-sans.woff2
FontFiles-->>Browser: jetbrains-mono.woff2
Browser->>Assets: Request optimized AVIF images
Assets-->>Browser: Compressed image files
Note over Browser: Accessibility enhancements:<br/>- ARIA labels on navigation<br/>- Role attributes for menu structure<br/>- Semantic HTML (h2 instead of h5)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 1 comment
No description provided.