Skip to content

reduce badge perf impact on pages#4872

Merged
Lendemor merged 2 commits intomainfrom
lendemor/badge_as_app_wrapper
Feb 25, 2025
Merged

reduce badge perf impact on pages#4872
Lendemor merged 2 commits intomainfrom
lendemor/badge_as_app_wrapper

Conversation

@Lendemor
Copy link
Contributor

The sticky badge showing Built with Reflex is now added as an app_wrap instead of injected in each page, reducing the impact on compilation length.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 25, 2025

CodSpeed Performance Report

Merging #4872 will not alter performance

Comparing lendemor/badge_as_app_wrapper (eb12bca) with main (98f5081)

Summary

✅ 12 untouched benchmarks

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nice

@Lendemor Lendemor merged commit e0e3397 into main Feb 25, 2025
43 checks passed
@Lendemor Lendemor deleted the lendemor/badge_as_app_wrapper branch February 25, 2025 17:58
masenf pushed a commit that referenced this pull request Feb 25, 2025
* reduce badge perf impact on pages

* small fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants