Skip to content

ENG-7314: Only check for valid app name once per config instance #5710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 2 commits into from
Aug 14, 2025
Merged

ENG-7314: Only check for valid app name once per config instance #5710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a81719c
ENG-7314: Only check for valid app name once per config instance
masenf Aug 13, 2025
be878c6
Update reflex/config.py
masenf Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions reflex/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,9 @@ class Config(BaseConfig):
See the [configuration](https://reflex.dev/docs/getting-started/configuration/) docs for more info.
"""

# Track whether the app name has already been validated for this Config instance.
_app_name_is_valid: bool = dataclasses.field(default=False, repr=False)

def _post_init(self, **kwargs):
"""Post-initialization method to set up the config.

Expand Down
5 changes: 4 additions & 1 deletion reflex/utils/prerequisites.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ def _check_app_name(config: Config):
else:
msg += f"Ensure app_name='{config.app_name}' in rxconfig.py matches your folder structure."
raise ModuleNotFoundError(msg)
config._app_name_is_valid = True


def get_app(reload: bool = False) -> ModuleType:
Expand All @@ -184,7 +185,9 @@ def get_app(reload: bool = False) -> ModuleType:
try:
config = get_config()

_check_app_name(config)
# Avoid hitting disk when the app name has already been validated in this process.
if not config._app_name_is_valid:
_check_app_name(config)

module = config.module
sys.path.insert(0, str(Path.cwd()))
Expand Down
Loading