add popup option for redirect

[adhami3310]

No description provided.

[linear]

ENG-7564 Add option to pop-up for rx.redirect

[greptile-apps]

Greptile Summary

This PR adds a popup option to the redirect function in Reflex, allowing external URLs to open in popup windows instead of regular browser tabs. The implementation includes both backend and frontend changes.

On the backend (reflex/event.py), the PR introduces function overloads to provide type safety - when is_external=True, a popup parameter becomes available, while when is_external=False, the existing replace parameter is used instead. This design prevents invalid parameter combinations and ensures developers can only use the popup option where it makes sense (external redirects only). The overloads use Python's Literal types for parameter validation.

On the frontend (reflex/.templates/web/utils/state.js), the JavaScript code is modified to handle the popup option by appending ,popup to the window.open() features string when event.payload.popup is true. This leverages the browser's built-in popup window functionality.

This change integrates well with Reflex's existing event system and follows the framework's patterns for handling browser navigation. The popup functionality is particularly useful for OAuth flows, payment gateways, and other third-party integrations where a popup window provides better user experience than full tab navigation. The implementation maintains backward compatibility since the popup option is opt-in.

Confidence score: 4/5

• This PR is safe to merge with minimal risk as it adds optional functionality without breaking existing behavior
• Score reflects well-structured type safety implementation and straightforward frontend changes, though lacks comprehensive testing coverage
• Pay close attention to the function overloads in reflex/event.py to ensure the type constraints work as expected

_{2 files reviewed, no comments}

_{Edit Code Review Bot Settings | Greptile}

[codspeed-hq]

CodSpeed Performance Report

Merging #5764 will not alter performance

_{Comparing khaleel/eng-7564-add-option-to-pop-up-for-rxredirect (8f3ee24) with main (dd993fd)}

Summary

✅ 8 untouched benchmarks