replace click exit with system exit

[adhami3310]

No description provided.

[greptile-apps]

Greptile Overview

Summary

This PR systematically replaces Click's `click.exceptions.Exit` with Python's built-in `SystemExit` exception across 9 files in the Reflex codebase. The changes are part of a dependency reduction effort to decouple utility modules from the Click CLI framework where it's not needed.

The primary changes include:

• Removing import click statements from utility modules
• Replacing raise click.exceptions.Exit(1) with raise SystemExit(1)
• Updating docstrings to reference SystemExit instead of Exit
• Maintaining identical exit codes and error handling behavior

This refactoring affects core utility modules including frontend skeleton initialization, process management, JavaScript runtime validation, template handling, file operations, and CLI validation. The change standardizes error handling across the codebase by using Python's standard library exception instead of Click-specific exceptions, making these utility functions more reusable in non-CLI contexts while reducing external dependencies.

The functionality remains identical since both click.exceptions.Exit and SystemExit result in program termination with the same exit codes, but the new approach is more lightweight and follows standard Python patterns.

Important Files Changed

Changed Files

Filename	Score	Overview
reflex/utils/frontend_skeleton.py	5/5	Replaces click.exceptions.Exit with SystemExit in requirements.txt initialization
reflex/utils/processes.py	5/5	Updates 5 locations to use SystemExit instead of click.exceptions.Exit for process management
tests/units/utils/test_utils.py	4/5	Updates test assertions to expect SystemExit instead of click.exceptions.Exit
reflex/custom_components/custom_components.py	2/5	Replaces click exits with SystemExit but has critical bug on line 522
reflex/utils/js_runtimes.py	5/5	Mechanical replacement of click exits with SystemExit in JavaScript runtime validation
reflex/utils/templates.py	5/5	Comprehensive replacement of click exits with SystemExit in template handling
reflex/utils/rename.py	5/5	Simple replacement of click exits with SystemExit in rename utilities
reflex/reflex.py	5/5	Updates CLI validation to use SystemExit instead of click.exceptions.Exit
reflex/utils/prerequisites.py	5/5	Replaces click exits with SystemExit in prerequisite validation functions

Confidence score: 3/5

• This PR contains mostly safe changes that standardize exit handling, but has one critical bug that prevents proper program termination
• Score lowered due to a critical syntax error in reflex/custom_components/custom_components.py line 522 where SystemExit(1) is used as a statement instead of being raised
• Pay close attention to reflex/custom_components/custom_components.py which has the missing raise keyword that will cause the program to continue execution instead of exiting

Sequence Diagram

sequenceDiagram
    participant User
    participant CLI as "reflex component init"
    participant CustomComponentsCLI as "custom_components.py"
    participant Validation as "_validate_library_name"
    participant DirectoryCheck as "_get_default_library_name_parts"
    
    User->>CLI: "reflex component init --library-name my-lib"
    CLI->>CustomComponentsCLI: "init(library_name, install)"
    CustomComponentsCLI->>CustomComponentsCLI: "Check if pyproject.toml exists"
    
    alt pyproject.toml already exists
        CustomComponentsCLI->>User: "SystemExit(1) - pyproject.toml already exists"
    else pyproject.toml does not exist
        CustomComponentsCLI->>Validation: "_validate_library_name(library_name)"
        
        alt library_name is None
            Validation->>DirectoryCheck: "_get_default_library_name_parts()"
            DirectoryCheck->>DirectoryCheck: "Clean current directory name"
            
            alt directory name starts with 'reflex'
                DirectoryCheck->>DirectoryCheck: "Remove 'reflex' prefix"
                alt no parts left after removal
                    DirectoryCheck->>User: "SystemExit(1) - Invalid library name"
                end
            end
            
            alt no valid parts found
                DirectoryCheck->>User: "SystemExit(1) - Could not find valid library name"
            end
            
            DirectoryCheck-->>Validation: "Return name parts"
        else library_name provided
            alt invalid library name format
                Validation->>User: "SystemExit(1) - Invalid characters in library name"
            end
        end
        
        Validation-->>CustomComponentsCLI: "Return NameVariants"
        CustomComponentsCLI->>CustomComponentsCLI: "_populate_custom_component_project()"
        CustomComponentsCLI->>CustomComponentsCLI: "_populate_demo_app()"
        
        alt install is True
            CustomComponentsCLI->>CustomComponentsCLI: "_pip_install_on_demand()"
            alt installation fails
                CustomComponentsCLI->>User: "SystemExit(1) - Installation failed"
            end
        end
        
        CustomComponentsCLI->>User: "Success message"
    end

Loading

Additional Comments (1)

1. tests/units/utils/test_utils.py, line 178 (link)

   logic: This commented-out assertion should either be removed or properly implemented. The test currently doesn't validate the expected exception.

Context used:

Rule from dashboard - Remove commented-out code before merging PRs. (source)

_{9 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[codspeed-hq]

CodSpeed Performance Report

Merging #5841 will not alter performance

_{Comparing replace-click-exit-with-system-exit (ecb51fc) with main (5feefe3)}

Summary

✅ 8 untouched

[masenf]

wouldn't raise SystemExit(1) suffice here if we didn't want to chain the exception?

[adhami3310]

ruff complains if we don't day from None