Skip to content

rolldown vite 7.1.16#5858

Merged
adhami3310 merged 4 commits intomainfrom
rolldown-vite-7116
Oct 9, 2025
Merged

rolldown vite 7.1.16#5858
adhami3310 merged 4 commits intomainfrom
rolldown-vite-7116

Conversation

@adhami3310
Copy link
Member

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR updates the rolldown-vite package from version 7.1.14 to 7.1.16 and removes unused browser interaction functionality. The primary change is a version bump of rolldown-vite, which is a faster alternative to the standard Vite bundler that Reflex uses for its frontend build process. The version is updated consistently in both the `DEV_DEPENDENCIES` and `OVERRIDES` sections of the installer constants to ensure version consistency across the dependency tree.

The second change removes the open_browser_and_wait function from reflex/utils/redir.py, which previously provided functionality to open a browser window and poll a URL until it returned successfully. This function appears to have become obsolete, likely replaced by other mechanisms in the codebase. Additionally, the webbrowser import has been moved from module-level to a local import within the open_browser function, following Python best practices for importing only when needed.

These changes fit into Reflex's broader frontend build infrastructure, where rolldown-vite serves as the build tool for the web frontend. The version update likely includes bug fixes, performance improvements, or compatibility updates that benefit the overall build process.

Important Files Changed

Changed Files
Filename Score Overview
reflex/constants/installer.py 5/5 Updated rolldown-vite package version from 7.1.14 to 7.1.16 in both DEV_DEPENDENCIES and OVERRIDES
reflex/utils/redir.py 4/5 Removed unused open_browser_and_wait function and moved webbrowser import to local scope

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it contains a straightforward dependency version bump and removal of unused code
  • Score reflects simple, non-breaking changes with consistent version updates and proper cleanup of obsolete functionality
  • No files require special attention as both changes are low-risk maintenance updates

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 8, 2025

CodSpeed Performance Report

Merging #5858 will not alter performance

Comparing rolldown-vite-7116 (1cc6a5f) with main (5fd8ea9)

Summary

✅ 8 untouched

@adhami3310 adhami3310 merged commit 590a260 into main Oct 9, 2025
61 of 63 checks passed
@adhami3310 adhami3310 deleted the rolldown-vite-7116 branch October 9, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants