Merged
Conversation
CodSpeed Performance ReportMerging #5933 will degrade performances by 28.18%Comparing Summary
Benchmarks breakdown
|
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR bumps the development version to 0.8.18dev1 and updates multiple dependencies to their latest versions.
Key Changes
- Version bump: Reflex version updated from 0.8.17dev1 to 0.8.18dev1
- Redis compatibility: Extended redis support from
<7.0to<8.0with backward-compatible handling of sync/asyncping()methods - Frontend tooling updates:
- Bun: 1.3.0 → 1.3.1
- Lucide icons: 0.546.0 → 0.548.0 (adds
birdhouseandgamepad_directional) - Tailwind CSS: 4.1.15 → 4.1.16
- Rolldown-vite: 7.1.18 → 7.1.20
- Python dependency updates:
reflex-hosting-cli: >=0.1.57 → >=0.1.58ruff: v0.14.1 → v0.14.2pyright: v1.1.406 → v1.1.407
Implementation Details
The most significant code change is in reflex/utils/prerequisites.py:436-441, where the redis ping check now uses inspect.isawaitable() to handle both synchronous (redis <7.0) and asynchronous (redis >=7.0) redis clients. This ensures backward compatibility while supporting newer redis versions.
Confidence Score: 5/5
- This PR is safe to merge with no identified issues
- All changes are routine dependency updates with proper backward compatibility handling. The redis compatibility fix correctly uses
inspect.isawaitable()to support both sync and async clients, and existing tests already cover this pattern. Version bumps are incremental and follow semantic versioning. - No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| pyproject.toml | 5/5 | Version bump to 0.8.18dev1, updated dependencies (redis <8.0, reflex-hosting-cli >=0.1.58, ruff v0.14.2, pyright v1.1.407, rolldown-vite@7.1.20) |
| reflex/components/lucide/icon.py | 5/5 | Updated lucide-react from 0.546.0 to 0.548.0, added two new icons: birdhouse and gamepad_directional |
| reflex/constants/installer.py | 5/5 | Updated Bun from 1.3.0 to 1.3.1, rolldown-vite from 7.1.18 to 7.1.20 |
| reflex/plugins/tailwind_v4.py | 5/5 | Updated tailwindcss and @tailwindcss/postcss from 4.1.15 to 4.1.16 |
| reflex/utils/prerequisites.py | 5/5 | Added inspect.isawaitable() check for redis ping() to handle both sync and async redis clients, supporting redis >=7.0 |
Sequence Diagram
sequenceDiagram
participant App as Application
participant Health as Health Endpoint
participant Redis as Redis Client
participant Inspect as inspect.isawaitable()
App->>Health: Request health status
Health->>Redis: get_redis()
alt Redis client exists
Health->>Redis: redis_client.ping()
Redis-->>Health: Returns ping command
Health->>Inspect: Check if awaitable
alt Command is awaitable (redis >=7.0)
Health->>Redis: await ping_command
Redis-->>Health: Ping response
else Command is not awaitable (redis <7.0)
Note over Health: Use result directly
end
Health-->>App: {"redis": True}
else Redis client is None
Health-->>App: {"redis": None}
end
6 files reviewed, no comments
masenf
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.