Skip to content

Conversation

@MatthewCollinsNZ
Copy link
Contributor

Adding a prop which makes rowMarker check boxses on data editors always visible instead of just on hover.

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 13, 2026

Greptile Summary

Added support for checkbox-visible row marker option to the DataEditor component. This new option makes row marker checkboxes always visible instead of only appearing on hover, providing better UX for users who need persistent checkbox visibility.

  • Added checkbox-visible to LiteralRowMarker type definition in literals.py
  • Updated documentation comment in dataeditor.py to include the new option in the list of valid row marker values

Confidence Score: 5/5

  • This PR is safe to merge with no risks
  • The changes are minimal, well-contained, and type-safe. Adding a new literal option to an existing type is a non-breaking additive change that simply exposes existing functionality from the underlying glide-data-grid library
  • No files require special attention

Important Files Changed

Filename Overview
reflex/components/datadisplay/dataeditor.py Updated comment to document the new "checkbox-visible" option for row_markers property
reflex/components/literals.py Added "checkbox-visible" literal to LiteralRowMarker type to enable always-visible checkboxes

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant DataEditor as DataEditor Component
    participant Literal as LiteralRowMarker Type
    participant Glide as glide-data-grid Library
    
    Dev->>DataEditor: Set row_markers="checkbox-visible"
    DataEditor->>Literal: Validate against LiteralRowMarker type
    Literal-->>DataEditor: ✓ Valid option
    DataEditor->>Glide: Pass row_markers prop to library
    Glide-->>DataEditor: Render checkboxes always visible
    DataEditor-->>Dev: Display data grid with persistent checkboxes
Loading

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 13, 2026

Greptile's behavior is changing!

From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section.

This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 13, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing MatthewCollinsNZ:origin/MatthewCollinsNZ/adddataeditorrowcheckboxvisible (341a421) with main (726711e)

Summary

✅ 8 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants