WIP: TagMap replacement #333
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treeowl
force-pushed
the
tag-map-replacement
branch
2 times, most recently
from
3e61306 to
a959857
Compare
Separate concerns for `TagMap`, add functionality, and try to manage the inherent unsafety a bit better. I don't really see what `MyTag` has to offer by way of optimization, so I haven't included that business. Maybe I'm missing something there...
treeowl
force-pushed
the
tag-map-replacement
branch
from
a959857 to
66298f0
Compare
|
I think this is hitting ndmitchell/hlint#818 |
Member
|
Yes everything is going to hit that, so just ignore it for now. Trying to fix. |
Member
|
Let's do this only if we are sure it can help requester after #371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate concerns for
TagMap, add functionality, and try tomanage the inherent unsafety a bit better. I don't really see
what
MyTaghas to offer by way of optimization, so I haven'tincluded that business. Maybe I'm missing something there...