Skip to content

Commit 19fbfb0

Browse files
author
Theofilos Manitaras
committed
Remove 'post_run' and 'pre_run' from 'Job'
* Remove the `pre_run` and `post_run` fields from class `Job`. * Remove the corresponding deprecation unit tests.
1 parent 7345432 commit 19fbfb0

File tree

2 files changed

+0
-38
lines changed

2 files changed

+0
-38
lines changed

reframe/core/schedulers/__init__.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -41,34 +41,6 @@ class Job(abc.ABC):
4141
#: :default: ``[]``
4242
options = fields.TypedListField('options', str)
4343

44-
#: List of shell commands to execute before launching this job.
45-
#:
46-
#: :type: :class:`list` of :class:`str`
47-
#: :default: ``[]``
48-
#:
49-
#: .. note::
50-
#: .. deprecated:: 2.10
51-
#: Please use the :attr:`reframe.core.pipeline.RegressionTest.pre_run`
52-
#: field instead.
53-
pre_run = fields.DeprecatedField(
54-
fields.TypedListField('_pre_run', str),
55-
'Use of the pre_run field of Job is deprecated. '
56-
'Please use the pre_run field of RegressionTest instead.')
57-
58-
#: List of shell commands to execute after launching this job.
59-
#:
60-
#: :type: :class:`list` of :class:`str`
61-
#: :default: ``[]``
62-
#:
63-
#: .. note::
64-
#: .. deprecated:: 2.10
65-
#: Please use the :attr:`reframe.core.pipeline.RegressionTest.post_run`
66-
#: field instead.
67-
post_run = fields.DeprecatedField(
68-
fields.TypedListField('_post_run', str),
69-
'Use of the post_run field of Job is deprecated. '
70-
'Please use the post_run field of RegressionTest instead.')
71-
7244
#: The parallel program launcher that will be used to launch the parallel
7345
#: executable of this job.
7446
#:

unittests/test_schedulers.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -225,16 +225,6 @@ def test_cancel_term_ignore(self):
225225
# Verify that the spawned sleep is killed, too
226226
self.assertProcessDied(sleep_pid)
227227

228-
def test_deprecated_pre_run_and_post_run(self):
229-
from reframe.core.exceptions import ReframeDeprecationWarning
230-
231-
self.assertWarns(ReframeDeprecationWarning, exec,
232-
'self.testjob.pre_run = []',
233-
globals(), locals())
234-
self.assertWarns(ReframeDeprecationWarning, exec,
235-
'self.testjob.post_run = []',
236-
globals(), locals())
237-
238228

239229
class TestSlurmJob(_TestJob):
240230
@property

0 commit comments

Comments
 (0)