Open
Conversation
iam28th
force-pushed
the
makefile-improvements
branch
from
4fd7e06 to
f48fcfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings!
There are some minor additions I'd like to make to the building process; I know that CoLoRd is currently not under active development, but hopefully it will still be of some help (I briefly checked, and it looks like similar changes -- if you like them:) -- can be implemented in other repositories).
PR consists of 2 commits:
(a spoiler with the picture to see what files these are; .gitignore was temporarily deleted to make them visible)
maketo automatically detect when a.cppfiles includes a recently modified header, and rebuild the corresponding object.Previously changes in
.hfiles were not picked up, which could lead to unexpected stuff when objects contained outdated logic; and the only solution to such problem would be tomake cleanand recompile everything anew every time.Now such situations will not happen when editing files in
src/colord.