feat: Governance schema extensions for agentic framework#51
feat: Governance schema extensions for agentic framework#51
Conversation
New LinkML schemas: Agent, WorkOrder, GovernanceDecision, VoiceCouncilSession, CoherenceCheck. Extended Entity.yaml with AGENT entityType. Extended taxonomy.yaml with governance enums (GovernanceLayer, GovernanceActionType, AgentDecisionType). Updated update-graph.sh for KOI Fuseki integration. Instance examples for all 5 schemas in playground/Governance/. All schemas pass linkml-lint (warnings only) and linkml-validate on instance examples. Part of regen-network/agentic-tokenomics#2 review follow-up. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ions
Security fixes (from Gemini code review):
- Fix command injection (RCE) in update-graph.sh and upload-ontology.sh:
use os.environ instead of shell interpolation for FUSEKI_GRAPH in Python
- Fix argument injection in curl commands: convert $AUTH from string to
bash array and use "${AUTH[@]}" for safe expansion (4 instances)
Schema fixes (from Codex and Gemini reviews):
- Rename evidenceIRIs to evidence in WorkOrder.yaml for consistency
with GovernanceDecision.yaml and CoherenceCheck.yaml
- Change CoherenceCheck.subjectId type from uriorcurie to string,
matching GovernanceDecision.subjectId and example data (bare IDs)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @glandua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the system's governance capabilities by introducing a comprehensive set of LinkML schemas designed for an agentic framework. It enables the definition and tracking of agents, work orders, governance decisions, voice council sessions, and coherence checks. Alongside these new features, critical security vulnerabilities related to script execution and argument handling have been patched, and schema consistency has been improved, ensuring a more robust and secure data infrastructure for managing complex governance workflows. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant extension to the governance schemas for the agentic framework, adding five new LinkML schemas and corresponding example data. It also includes important security fixes and improvements to the data upload scripts for Fuseki and Oxigraph integration.
The new schemas for Agent, WorkOrder, GovernanceDecision, VoiceCouncilSession, and CoherenceCheck are well-defined and consistently structured. The example data files are helpful for understanding their usage.
The script updates are a major improvement. The security vulnerabilities related to command and argument injection have been correctly addressed by using bash arrays for arguments and safe environment variable access in Python.
I've added a couple of minor suggestions to the shell scripts to improve consistency and robustness. Overall, this is a high-quality contribution.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Apply the same bash array pattern for --user credentials as update-graph.sh, per Gemini review. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
Governance LinkML schemas for the agentic framework, based on @DarrenZal's work in #50 with security and schema review fixes applied.
AGENTentityTypeplayground/Governance/Review fixes applied (supersedes #50)
Security (Critical/High):
update-graph.shandupload-ontology.sh:FUSEKI_GRAPHwas shell-interpolated into Python strings. Now usesos.environfor safe access.$AUTHconverted from string to bash array with"${AUTH[@]}"expansion (4 instances inupdate-graph.sh)Schema (Medium/P2):
evidenceIRIs→evidenceinWorkOrder.yamlfor consistency withGovernanceDecision.yamlandCoherenceCheck.yamlCoherenceCheck.subjectIdtype fromuriorcurie→stringto matchGovernanceDecision.subjectIdand example data (bare IDs likeWO-001)CI note
Cloudflare Pages deploy check fails due to missing
apiTokenrepo secret — this is a pre-existing infrastructure issue, not related to this PR. TheValidate and Convert datacheck passes.Test plan
linkml-lintpasses on all 5 new schemaslinkml-validatepasses on all 5 instance examplesmakeinschema/completes without errorsCloses #50
🤖 Generated with Claude Code