Skip to content

fix: APP-536 show regen address instead of account id in user profile#2585

Merged
r41ph merged 1 commit intodevfrom
APP-536-account-id-rather-than-regen-address
Jan 27, 2025
Merged

fix: APP-536 show regen address instead of account id in user profile#2585
r41ph merged 1 commit intodevfrom
APP-536-account-id-rather-than-regen-address

Conversation

@r41ph
Copy link
Contributor

@r41ph r41ph commented Jan 22, 2025

Description

https://regennetwork.atlassian.net/browse/APP-536

I have noticed that when clicking on the link to 'mintscan.io' it doesn't work with the account id but it does with the regen address, so I have changed it, review this too please.

The same thing doesn't work either in dev, is this known? In dev it points to 'https://redwood.regen.aneka.io/accounts/' instead of mintscan.io.

Author Checklist

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. https://deploy-preview-2585--regen-marketplace.netlify.app/
  2. Check the profile page of organization accounts show the regen address instead of the account id
  3. Check that when clicking on the regen address the link works and mintscan.io loads as expected.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 039d403
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/67974af241e61d000804d195
😎 Deploy Preview https://deploy-preview-2585--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 039d403
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/67974af27fdf730008c84567
😎 Deploy Preview https://deploy-preview-2585--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r41ph
Copy link
Contributor Author

r41ph commented Jan 22, 2025

@erikalogie @S4mmyb see testing instructions please.

@r41ph r41ph requested a review from blushi January 22, 2025 19:30
@S4mmyb
Copy link
Member

S4mmyb commented Jan 23, 2025

LGTM

@erikalogie
Copy link
Collaborator

LGTM though on dev as you already noted the account address does not link to mint scan

@blushi
Copy link
Member

blushi commented Jan 23, 2025

The same thing doesn't work either in dev, is this known? In dev it points to 'https://redwood.regen.aneka.io/accounts/' instead of mintscan.io.

@r41ph
dev uses redwood testnet whereas mintscan has a block explorer for mainnet only so far, this is why it's different (this is defined in the env var VITE_BLOCK_EXPLORER)
We are aware https://redwood.regen.aneka.io block explorer has been down for some time and we are still awaiting a new one, although Cory had shared with me that mintscan could provide one but looking at the testnets list on https://www.mintscan.io/, it's not there yet...

@blushi
Copy link
Member

blushi commented Jan 27, 2025

I have noticed that when clicking on the link to 'mintscan.io' it doesn't work with the account id but it does with the regen address, so I have changed it, review this too please.

It's totally normal, the account uuid is the internal user reference in our db so mintscan is not supposed to be aware of that, it's only aware of what is on chain, which is the wallet address.

@r41ph r41ph force-pushed the APP-536-account-id-rather-than-regen-address branch from a635ec8 to 039d403 Compare January 27, 2025 08:59
@r41ph r41ph merged commit c40755e into dev Jan 27, 2025
14 checks passed
@r41ph r41ph deleted the APP-536-account-id-rather-than-regen-address branch January 27, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants