feat: APP-441 update account name during buy credits flow#2596
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@erikalogie @S4mmyb see testing instructions. |
|
This does not seem to be working, the name I provided appears on the credit retirement certificate but not in the user dropdown, or on the user profile |
| }); | ||
| } | ||
|
|
||
| if (name && !activeAccount?.name && !noAccountAndNoWallet) { |
There was a problem hiding this comment.
you will also need to invalidate the getAccount query, see how it's done in refreshProfileData in ProfileEditMain
There was a problem hiding this comment.
you can just check !!activeAccount instead of !noAccountAndNoWallet
There was a problem hiding this comment.
this should happen for logged in users
I believe that logic checks if the user is logged in
There was a problem hiding this comment.
I've updated my comment, check the new comment above
you should only check for activeAccount
we don't care about a wallet being there or not in this case
There was a problem hiding this comment.
you will also need to invalidate the getAccount query, see how it's done in
refreshProfileDatainProfileEditMain
@r41ph this still needs to be addressed, for the name update to appear without reloading the page
@erikalogie I've just tried it again and it seems to be working as expected. Can you share more about how you are testing it please? |
I made a new email account and then went through the buy flow. I just tried it again and it is working now. |
|
this worked for me |
r41ph
force-pushed
the
feat-APP-441-save-account-name-on-purchase
branch
from
f9fa9d5 to
c8a1899
Compare
r41ph
force-pushed
the
feat-APP-441-save-account-name-on-purchase
branch
from
c8a1899 to
3d92c57
Compare
blushi
left a comment
blushi
left a comment
There was a problem hiding this comment.
Pre-approving, pending small adjustment
| } | ||
|
|
||
| if (name && activeAccount?.id && !activeAccount?.name) { | ||
| updateAccountById({ |
There was a problem hiding this comment.
best to wait for this to succeed before refreshing profile data
| updateAccountById({ | |
| await updateAccountById({ |
r41ph
force-pushed
the
feat-APP-441-save-account-name-on-purchase
branch
from
3d92c57 to
0b260ea
Compare
4 participants
Description
https://regennetwork.atlassian.net/browse/APP-441
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...