Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@erikalogie @S4mmyb see testing instructions |
|
Looks good, just the tooltip icon is not in the right place, if it is possible to put it here: Also the "?" icon doesn't need to be bigger, it looks bigger now. |
@erikalogie I've just made it look like it is in the comps: |
Oh you are right, whoops. All good then. |
r41ph
left a comment
r41ph
left a comment
There was a problem hiding this comment.
Unrelated to this change, but I noticed that in Order.SummaryRow.tsx:28 the <p> shouldn't be a <p> because in some situations we end up with a <p> as a descendant of this <p>. Would it make sense to update it in this PR, or should we create a separate issue for it?
| <Title | ||
| variant="h2" | ||
| className="mt-10 sm:mt-0 mb-5 text-[21px] leading-[1.5]" | ||
| className="mt-10 md:mt-0 mb-5 text-[21px] leading-[1.5]" |
There was a problem hiding this comment.
The title still gets too close to the buttons, maybe a bit of padding will sort it out:
...
<Title
variant="h2"
className="... pr-10"
...
I believe it's the same with the <ProjectPlaceInfo> below in line 150, still classes with the buttons:
...
subheader={
<>
<div className="... pr-10">
...
There was a problem hiding this comment.
Re the above comment:
Also, I've noticed that prices can get too long and get cut in some screen sizes. Should this be 6 decimals max @blushi?
There was a problem hiding this comment.
I think this might be a float precision issue again, thanks for catching
You mean a div descendant of p?
|
Check in Payment Info. There is a
|
Ok I see, so we should probably replace the outer p and it will solve both of these issues |
blushi
force-pushed
the
fix-APP-556-orders-ui
branch
from
63202fc to
ef4bb24
Compare
3 participants
Description
Closes: https://regennetwork.atlassian.net/browse/APP-556
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
https://deploy-preview-2597--regen-marketplace.netlify.app/dashboard/admin/my-orders
Log in with an account that has made some crypto and/or fiat orders and check out your orders.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...