Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| let href = ''; | ||
| if (baseDenom === GRAVITY_USDC_DENOM) | ||
| href = 'https://regen-registry.s3.us-east-1.amazonaws.com/usdc.grv.png'; |
There was a problem hiding this comment.
we need image urls to use in the confirmation email
maybe we could set them as env var?
but not sure it's gonna change very often so maybe it's fine to have it hardcoded here
thoughts @r41ph?
There was a problem hiding this comment.
If the URLs are not going to change often and they are consistent between environments, we probably don't need them in env vars. We could use a config file instead or constants but if it's not likely that we are going to use them anywhere else in the codebase, we could just kepp them hardcoded.
Regarding the URL, do we have more images or icons in S3? I wonder if we should move the images to a dedicated directory, i.e: like /assets/icons maybe?: https://regen-registry.s3.us-east-1.amazonaws.com/assets/icons/****.png
There was a problem hiding this comment.
sure, just updated, also check out https://github.com/regen-network/regen-server/pull/525/files
|
@erikalogie @S4mmyb see testing instructions |
|
the email LGTM but this page of the form is weird: |
blushi
force-pushed
the
feat-APP-551-crypto-purchase-email
branch
from
b2ac6f4 to
7095554
Compare
this should be fixed @erikalogie |
LGTM |
blushi
force-pushed
the
feat-APP-551-crypto-purchase-email
branch
from
b18d810 to
9374f46
Compare
3 participants
Description
Needs https://github.com/regen-network/regen-server/pull/524 before it can be tested
Closes: https://regennetwork.atlassian.net/browse/APP-551
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
From https://deploy-preview-2599--regen-marketplace.netlify.app/project/C01-001/buy, log in with Keplr and buy some credits with crypto (retired then tradable) to receive the email confirmation. Don't forget to provide an email in the form if your account doesn't have any email connected to it yet.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...