Conversation
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @blushi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the retrieval and display of data anchoring and attestation events within the application. By integrating a new GraphQL endpoint that provides indexed data events, the previous, more complex method of querying raw Cosmos SDK transaction events has been replaced. This change enhances performance and simplifies the codebase responsible for displaying event history on data post pages. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the data fetching logic for attest and anchor events to use a new indexed GraphQL query. This is a significant improvement, simplifying the code by replacing multiple on-chain queries with a single, more performant call to the indexer. The changes in useAttestEvents.ts are well-executed, and the related query files are structured correctly. I've included a couple of minor suggestions to further improve code quality and performance.
...s/react-query/registry-server/graphql/indexer/getAllDataEventsByIri/getAllDataEventsByIri.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7a8a4aeb6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@erikalogie @S4mmyb see testing instructions |
|
LGTM, looks much quicker |
|
LGTM! |
...s/react-query/registry-server/graphql/indexer/getAllDataEventsByIri/getAllDataEventsByIri.ts
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
d1a959b to
b681e76
Compare
Description
https://regennetwork.atlassian.net/browse/APP-852
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Access a data post page with some anchoring and signing (=attesting) events, eg https://deploy-preview-2791--regen-marketplace.netlify.app/post/regen:13toVgeD4XUWeRipVg1L8bxoubPHkkVy8k2sfrgNFbRr6woZu3RdyqN.rdf
Check performance is better
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...