fix: APP-871 overlay and text shadow in project dashboard banner#2798
fix: APP-871 overlay and text shadow in project dashboard banner#2798
Conversation
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @blushi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue (APP-871) where text on the project dashboard banner could be difficult to read, particularly when a project featured a white or light-colored background image. The changes enhance text visibility and contrast by adjusting the overlay color and applying a subtle text shadow to key textual elements, thereby improving the overall user experience and legibility of important information. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with text visibility on the project dashboard banner by adding an overlay and text shadows. The changes look good and should fix the problem. I've made a couple of suggestions to improve the implementation of the text shadow by using a more modern CSS feature that simplifies the code and improves maintainability. Specifically, using drop-shadow instead of the text-shadow with padding/negative-margin hack.
web-marketplace/src/components/organisms/ProjectDashboardBanner/ProjectDashboardBanner.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/ProjectDashboardBanner/ProjectDashboardBanner.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74875dd0ab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
web-marketplace/src/components/organisms/ProjectDashboardBanner/ProjectDashboardBanner.tsx
Outdated
Show resolved
Hide resolved
|
@erikalogie @S4mmyb see testing instructions |
|
LGTM! Curious @blushi if in playing around with filters you feel like it could go lighter, or if that feels pretty good. |
thoughts @erikalogie ? |
I think this looks good! Can't go much lighter with the black overlay otherwise the text is not visible on top of it. |
cefa8f6 to
f390468
Compare
Description
https://regennetwork.atlassian.net/browse/APP-871
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Check the project dashboard page for some project with a white image
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...