feat: APP-855 implement data posts table in dashboard projects#2810
feat: APP-855 implement data posts table in dashboard projects#2810alexander-astrand wants to merge 15 commits intodevfrom
Conversation
Summary of ChangesHello @alexander-astrand, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant new feature to the project management dashboard: a dedicated section for managing 'Data Posts'. It provides a structured table view for data posts, allowing users to see details like title, creation date, author, privacy settings, and file counts. The implementation includes robust data fetching, account resolution, and sorting capabilities, enhancing the user's ability to oversee and interact with their project's data contributions. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
The pull request successfully scaffolds the data post table and fetching logic for the project management dashboard. The implementation follows the existing patterns in the codebase, using TanStack Query for data fetching and a custom table component for display. However, there are some performance and logic issues that should be addressed, particularly regarding the memoization of sorting logic and the mismatch between infinite query fetching and table pagination.
web-marketplace/src/legacy-pages/Dashboard/MyProjects/ManageProject.DataPosts.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/DataPostsTable/useSortedDataPosts.ts
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/DataPostsTable/useSortedDataPosts.ts
Outdated
Show resolved
Hide resolved
9809010 to
4df422c
Compare
|
@erikalogie @S4mmyb See testing instructions. |
is this actually testable without the related server changes https://github.com/regen-network/regen-server/pull/563?? |
web-marketplace/src/legacy-pages/Dashboard/MyProjects/ManageProject.DataPosts.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4df422c453
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
web-marketplace/src/legacy-pages/Dashboard/MyProjects/ManageProject.DataPosts.tsx
Outdated
Show resolved
Hide resolved
|
Nice work! A few issues I found: The colors of these icons seem to have been changed from green to red: https://www.loom.com/share/bba30399d3174c618b8983f492328cc3?from_recorder=1&focus_title=1 https://www.loom.com/share/c56c65bb194f4b9ab7582cecb711d99b?from_recorder=1&focus_title=1 On mobile the sizing and spacing is a bit smaller, see this comp: https://www.figma.com/design/L3VpDxt1PXTATPbSY0Z7DV/Organizations--org-member-permissions--and-project-collaborator-permissions?node-id=3811-94332&t=SykQOXWArofrjcyn-1 |
…t PostForm icon styles
| } | ||
|
|
||
| // "Delete Post" is available for published posts only | ||
| if (post.published && onDeletePost) { |
There was a problem hiding this comment.
draft posts can actually be deleted (see PostAdminButton) I think this comment on figma is a bit misleading https://www.figma.com/design/L3VpDxt1PXTATPbSY0Z7DV/Organizations--org-member-permissions--and-project-collaborator-permissions?node-id=5895-96469&m=dev
I guess it just means that only "delete post" is available to published posts (no edit possible)
web-marketplace/src/components/organisms/DataPostsTable/DataPostsTable.tsx
Show resolved
Hide resolved
web-marketplace/src/components/organisms/DataPostsTable/DataPostsTable.utils.ts
Outdated
Show resolved
Hide resolved
web-marketplace/src/legacy-pages/Dashboard/MyProjects/ManageProject.DataPosts.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/DataPostsTable/DataPostsTable.constants.ts
Outdated
Show resolved
Hide resolved
web-marketplace/src/legacy-pages/Dashboard/MyProjects/ManageProject.DataPosts.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/legacy-pages/Dashboard/MyProjects/ManageProject.DataPosts.tsx
Outdated
Show resolved
Hide resolved
|
@alexander-astrand I'm able to see data posts on the project page, but not in the data posts table. For example: |
this is now using server side pagination so needs https://github.com/regen-network/regen-server/pull/563 before it can be tested again |
@erikalogie @S4mmyb This is merged now so this PR is testable again! |
|
Should I be able to create a data post here on this branch as well? https://www.dropbox.com/scl/fi/1ml2klqppcrr2ir3b5jk8/Screenshot-2026-03-10-at-11.04.32-AM.png?rlkey=zqf43kep5rmpqcm4cnz42qqic&dl=0 This happened when trying to sign as myself, not as the org |
|
Issue with creating draft flow: https://www.loom.com/share/ce7915fb7f9b462a965a2ac9651e5ccd?from_recorder=1&focus_title=1 |
|
I also think that the names of the data posts should link to that data post page |
|
The title sorting does not appear to work correctly (it is not working alphabetically). I think we should not have the Author sorting triangle if there is only one author. In "..." menu, it should read "Edit draft", "Delete post" with second word not capitalized. |
|
@erikalogie looks like your previous image didn't get uploaded |

Description
https://regennetwork.atlassian.net/browse/APP-855
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...