Skip to content

chore: APP-897 enable back language switcher#2814

Open
blushi wants to merge 2 commits intomainfrom
chore-enable-i18n
Open

chore: APP-897 enable back language switcher#2814
blushi wants to merge 2 commits intomainfrom
chore-enable-i18n

Conversation

@blushi
Copy link
Member

@blushi blushi commented Mar 17, 2026

Description

Hot fix targeting main branch
Do not merge from github, follow https://www.notion.so/regennetwork/Release-process-for-regen-web-3dce8a42813b466fa46d44e8723a3b62?source=copy_link#3406c219896c4d3eaba9f1a14e1b5fc8


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit ecaa437
🔍 Latest deploy log https://app.netlify.com/projects/terrasos/deploys/69b97745d5153f0008e2fa8d
😎 Deploy Preview https://deploy-preview-2814--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on restoring the language switching capability across the website. By re-enabling a previously disabled component and integrating necessary utilities, the change allows users to select their preferred language, enhancing the internationalization of the platform.

Highlights

  • Language Switcher Re-enabled: The previously commented-out LanguageSwitcher component has been re-enabled within the LayoutHeader component, restoring multilingual functionality to the website.
  • Dependency Imports: The cn utility for conditional class names and the LanguageSwitcher component itself were imported to support the re-enabled functionality.
  • Home Page Detection: A new isHome variable was introduced to conditionally apply styling to the language switcher when on the home page.
Changelog
  • web-marketplace/src/components/layout/Layout.Header.tsx
    • Imported the cn utility for dynamic class name generation.
    • Imported the LanguageSwitcher component to be used in the header.
    • Added a new isHome constant to check if the current path is the root.
    • Uncommented and re-enabled the LanguageSwitcher component, making it visible in the header.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables the LanguageSwitcher component. While the change is simple, it surfaces a couple of underlying issues. Firstly, the LanguageSwitcher component itself appears to have internationalization problems, including hardcoded strings, which contradicts the reason it was previously commented out (pending translations). Secondly, the component is styled with an invalid Tailwind CSS class mr-25. I've provided specific feedback on both points in the review comments.

@blushi blushi changed the title chore: enable back language switcher chore: APP-897 enable back language switcher Mar 17, 2026
@blushi blushi requested a review from S4mmyb March 17, 2026 16:52
@S4mmyb
Copy link
Member

S4mmyb commented Mar 17, 2026

Just tested this on mobile and noticed two bugs:

  • first is that there doesn't seem to be the button for language switching.
  • second, the button to open the hamburger menu where
    the language switcher and other drop-downs should be opens then immediately closes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants