volume: avoid logging error while detecting pulseaudio

[mpareja]

The volume script attempts to detect pulseaudio by calling pactl. On machines without pactl installed, the detection generates a steady stream of noise in the logs, journalctl --follow shows:

regolith-session-x11[4037999]: /usr/share/i3xrocks/scripts/volume: line 38: pactl: command not found

Closes #154.

[kgilmer]

Hi @mpareja , thanks for the fix and clear description. Looking at the script, I wonder if pactl is an optional or required dependency. The script looks to me like it's required, and if so, I suggest this fix instead, which simply requires that the package providing pactl is installed as well ~

diff --git a/debian/control b/debian/control
index fb287fd..04b4252 100644
--- a/debian/control
+++ b/debian/control
@@ -140,7 +140,8 @@ Package: i3xrocks-volume
 Architecture: any
 Depends: ${misc:Depends},
     regolith-i3xrocks-config,
-    alsa-utils
+    alsa-utils,
+    pulseaudio-utils
 Description: Indicator to show volume.
  An i3xrocks indicator for showing the current sound volume.

LMK what you think :)

[mpareja]

From what I can tell, pactl is only used to detect which device to manipulate using amixer (which is a required dependency). I don't think we should require installing the pulse audio tools.

[kgilmer]

LGTM