Properly use colors for rofication message count#158
Properly use colors for rofication message count#158ralphm wants to merge 1 commit intoregolith-linux:masterfrom
Conversation
Unlike the `battery` script, this script uses `{$color:-}` ahead of the
xrescat call. As `color` is always provided, it takes precedence and the
warning and critical colors are never used. This change ignores $color
and just uses the result from the respective xrescat calls.
Arguably the fallback values should not be #D8DEE9 for all, but I expect
the referenced resources to be there at all times.
|
Hi @ralphm , thanks for your fix! Can you briefly describe how you tested this? |
|
@kgilmer sure. When there are no notifications, the script will emit an empty message bubble icon, and the count of 0 in white or light gray (the usual value colors) . I then create a new notifications using $ notify-send "Hello"This will yield an increased count. This count should be yellow, but comes out as white before this change. The icon switches to a filled message bubble. $ notify-send -u critical "Oops"This creates a notification with urgency critical. This should switch the value to be two numbers separated by a slash to denote the number of critical and normal notifications respectively. E.g. Note that the default action ( |
2 participants
Unlike the
batteryscript, this script uses{$color:-}ahead of the xrescat call. Ascoloris always provided, it takes precedence and the warning and critical colors are never used. This change ignores $color and just uses the result from the respective xrescat calls.Arguably the fallback values should not be
#D8DEE9for all, but I expect the referenced resources to be there at all times.