Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 areas that have bothered me when using penguin.
The first is the
calculate_scorefunction which we often see errors out of when repeatedly running Ctrl + C in a rehosting. This PR makes that function much more resilient to issues.The second is around patch conflicts. Previously, conflicts were written out every time we load our config (at least twice) and they looked like:
This information is useful, but it's hard to know exactly what is going on here. Which config patch set it originally? Which overrode it? Why is it printed so much?
This PR makes those more readable and actionable by providing a cleaner name for the config option, the old/new value, and the names of the config patches that held and then were overwritten. In the case that it is in our core config we list it as
base_configWe've also dropped this down from warning to info and updated the settings around it so we only ever see this when we call with
verbose=Truewhich we only ever do in penguin_run.