Upgrade gitlibs. This also address the issue with private keys#58
Upgrade gitlibs. This also address the issue with private keys#58sanel wants to merge 1 commit intoreifyhealth:developfrom
Conversation
tools.gitlibs now uses `git` directly, instead of Jsch, so workarounds are no longer necessary. Password protected private keys are now handled just like they are done through normal `git` command. Addressing reifyhealth#57
|
I haven't updated README.md and I just tested it against a private github repository, which works without problems. |
|
This PR is being flagged as STALE because it has not had recent activity in the last 60 days. It will be closed if no further activity occurs in the next 14 days. If you believe this repo should be excluded from this process, please add the repo to this list. |
|
@manderson202 Are there objections to the changes in this PR? |
|
Hi, thanks for the PR and the feedback here... sorry we haven't been able to get back on this. I did pull down the code and the integration tests failed for me, but I didn't get a chance to troubleshoot why. If you can get the tests passing I can take another look. |
|
This PR is being flagged as STALE because it has not had recent activity in the last 60 days. It will be closed if no further activity occurs in the next 14 days. If you believe this repo should be excluded from this process, please add the repo to this list. |
|
Hi, I've taken a quick look at why the tests fail. It seems to be because the test-project references the version that's set in the PR ("0.4.2"), but that can't be found. Running locally with this PR linked in the checkouts, the tests ran fine. Can I do anything to help move this along? |
|
Is the version bump in the |
tools.gitlibs now uses
gitdirectly, instead of Jsch, so workarounds are no longer necessary. Password protected private keys are now handled just like they are done through normalgitcommand.Addressing #57