Skip to content

nsis: add missing file.close()#138

Open
GerardoAllende wants to merge 1 commit intoreingart:developfrom
GerardoAllende:patch-1
Open

nsis: add missing file.close()#138
GerardoAllende wants to merge 1 commit intoreingart:developfrom
GerardoAllende:patch-1

Conversation

@GerardoAllende
Copy link
Copy Markdown
Contributor

Summary

Missing file.close() can cause errors when file is read before the garbage collector closes the file.

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)
  • Test coverage with pytest implemented
  • Reviewers assigned (at least 1 mentor)

Manual test evidence

(attach command-line examples, execution output & logs, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant