fix: cast record ID to string to prevent JS precision loss with snowflake IDs#92
Merged
ManukMinasyan merged 1 commit into4.xfrom Mar 6, 2026
Merged
Conversation
…ision loss Large integer IDs (e.g. snowflakes like 420533451316027392) exceed JavaScript's Number.MAX_SAFE_INTEGER (2^53 - 1). When passed through @js() in Blade, they were encoded as JSON numbers, causing silent precision loss in the browser. Casting to string at the data layer ensures @js() emits a quoted string, which JavaScript preserves exactly. Closes #88
There was a problem hiding this comment.
Pull request overview
This PR ensures board record IDs are serialized as strings so Blade @js() emits JSON strings (not numbers), preventing JavaScript precision loss for large integer (snowflake/bigint) primary keys.
Changes:
- Cast
$record->getKey()to string informatBoardRecord()to avoid JSNumberprecision truncation. - Add a regression test covering the string ID formatting behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Concerns/HasBoardRecords.php |
Forces formatted board record IDs to be strings at the data layer. |
tests/Feature/SnowflakeIdPrecisionTest.php |
Adds regression coverage asserting formatted IDs are strings and demonstrating JSON encoding differences. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$record->getKey()to string informatBoardRecord()so@js()emits a JSON string instead of a numberNumber.MAX_SAFE_INTEGER(2^53 - 1)Fixes the root cause at the data layer rather than patching individual Blade template usages.
Closes #88
Test plan
SnowflakeIdPrecisionTestverifiesformatBoardRecordreturns ID as string