Skip to content

feat: restore slippage UI component #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedromcunha merged 4 commits into from
Dec 10, 2024
Merged

feat: restore slippage UI component #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7167e6
feat: changeset
devin-ai-integration[bot] Dec 10, 2024
360b422
feat: restore slippage UI component
devin-ai-integration[bot] Dec 10, 2024
5f040b2
chore: remove all lock file changes
devin-ai-integration[bot] Dec 10, 2024
bcf479a
chore: completely remove lock file changes
devin-ai-integration[bot] Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-feet-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@reservoir0x/relay-kit-ui': patch
---

Restore slippage UI component in transaction review step
105 changes: 52 additions & 53 deletions packages/ui/src/components/common/TransactionModal/steps/ReviewQuoteStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,59 +116,58 @@ export const ReviewQuoteStep: FC<ReviewQuoteProps> = ({

let breakdown: { title: string; value: ReactNode }[] = []

//This is temporarily removed until we can work out better slippage estimation
// if (
// minimumAmountFormatted &&
// quote?.details?.slippageTolerance?.destination?.percent &&
// quote.details.slippageTolerance.destination.percent != '0.00'
// ) {
// breakdown.push({
// title: 'Min. Received',
// value: (
// <Flex
// align="center"
// direction="column"
// css={{
// gap: '1'
// }}
// >
// <Text style="subtitle2">
// {minimumAmountFormatted} {toToken?.symbol}
// </Text>
// <Tooltip
// align="end"
// side="top"
// content={
// <Text style="subtitle2" css={{ maxWidth: 235 }}>
// Automatic slippage tolerance is applied to every trade. The
// option to adjust slippage will be available soon.
// </Text>
// }
// >
// <div>
// <Flex css={{ gap: '1' }} align="center">
// <Text style="body3" color="subtle">
// Slippage:{' '}
// {quote?.details?.slippageTolerance?.destination?.percent ?? 0}
// %
// </Text>
// <Flex css={{ color: 'gray9' }}>
// <FontAwesomeIcon
// icon={faInfoCircle}
// width={14}
// height={14}
// style={{
// display: 'inline-block'
// }}
// />
// </Flex>
// </Flex>
// </div>
// </Tooltip>
// </Flex>
// )
// })
// }
if (
minimumAmountFormatted &&
quote?.details?.slippageTolerance?.destination?.percent &&
quote.details.slippageTolerance.destination.percent != '0.00'
) {
breakdown.push({
title: 'Min. Received',
value: (
<Flex
align="center"
direction="column"
css={{
gap: '1'
}}
>
<Text style="subtitle2">
{minimumAmountFormatted} {toToken?.symbol}
</Text>
<Tooltip
align="end"
side="top"
content={
<Text style="subtitle2" css={{ maxWidth: 235 }}>
Automatic slippage tolerance is applied to every trade. The
option to adjust slippage will be available soon.
</Text>
}
>
<div>
<Flex css={{ gap: '1' }} align="center">
<Text style="body3" color="subtle">
Slippage:{' '}
{quote?.details?.slippageTolerance?.destination?.percent ?? 0}
%
</Text>
<Flex css={{ color: 'gray9' }}>
<FontAwesomeIcon
icon={faInfoCircle}
width={14}
height={14}
style={{
display: 'inline-block'
}}
/>
</Flex>
</Flex>
</div>
</Tooltip>
</Flex>
)
})
}

breakdown = [
...breakdown,
Expand Down