Skip to content

Fix token overflow ui bug on token selector #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedromcunha merged 2 commits into from
Jan 3, 2025
Merged

Fix token overflow ui bug on token selector #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17a818
Fix token overflow ui bug on token selector
ted-palmer Dec 20, 2024
5193c1a
feat: changeset
ted-palmer Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sixty-zoos-tap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@reservoir0x/relay-kit-ui': patch
---

Fix token overflow ui bug on token selector
8 changes: 6 additions & 2 deletions packages/ui/src/components/common/TokenSelector/TokenSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,10 @@ const TokenSelector: FC<TokenSelectorProps> = ({
trigger={trigger}
css={{
p: '4',
overflowY: 'clip',
display: 'flex',
flexDirection: 'column',
height: 'auto',
maxHeight: 'min(85vh, 600px)',
'@media(min-width: 660px)': {
minWidth:
size === 'desktop'
Expand All @@ -581,7 +584,8 @@ const TokenSelector: FC<TokenSelectorProps> = ({
width: '100%',
height: '100%',
gap: '3',
position: 'relative'
position: 'relative',
overflowY: 'hidden'
}}
>
{tokenSelectorStep === TokenSelectorStep.SetCurrency ? (
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/common/TokenSelector/steps/SetChainStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export const SetChainStep: FC<SetChainStepProps> = ({
gridTemplateColumns: isDesktop ? 'repeat(2, minmax(0, 1fr))' : 'none',
gridColumnGap: isDesktop ? '8px' : '0',
gridAutoRows: 'min-content',
height: 530,
maxHeight: 530,
overflowY: 'auto',
pb: '2',
gap: isDesktop ? '0' : '2',
Expand Down
4 changes: 3 additions & 1 deletion packages/ui/src/components/common/TokenSelector/steps/SetCurrencyStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,9 @@ export const SetCurrencyStep: FC<SetCurrencyProps> = ({
>
Select Token
</Text>
<Flex css={{ width: '100%', gap: '3', height: '530px' }}>
<Flex
css={{ width: '100%', gap: '3', height: '100%', overflowY: 'hidden' }}
>
{isDesktop && (!configuredChainIds || configuredChainIds.length > 1) ? (
<>
<Flex
Expand Down
Loading